Conversation
The option `--no-crankshaft` is no longer available as of V8 6.0
|
Would like to see this land in less than 48 hours if there are no objections |
|
@MylesBorins this properly works without #14004? |
|
@Fishrock123 the original change works properly on master afaict. I rebased #14004 and now we have the failures |
|
@Fishrock123 V8 5.9 (currently in master) already has crankshaft disabled by default. This PR LGTM. |
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. Seems like a sufficiently small change that fast-tracking is 👌 by me.
|
odd, the CI never updated this even though it completed successfully... |
The option `--no-crankshaft` is no longer available as of V8 6.0 PR-URL: nodejs#14531 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in 7128e3c |
@Fishrock123 CI has been that way for at least two weeks now, perhaps longer. I think @phillipj was pinged about it at some point, but if you want to take a look and see if you can figure out why the bot + CI isn't updating widgets anymore, that would be great. |
The option `--no-crankshaft` is no longer available as of V8 6.0 PR-URL: #14531 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
6 participants
The option
--no-crankshaftis no longer available as of V8 6.0This needs to land to get the test suite working for #14004